Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451689158
##########
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##########
@@ -472,10 +516,11 @@ public void testCreateAlterTopicWithRackAware(String
quorum) throws Exception {
"--topic", testTopicName);
topicService.alterTopic(alterOpts);
+ TestUtils.waitForAllReassignmentsToComplete(adminClient, 100L);
kafka.utils.TestUtils.waitUntilTrue(
() -> brokers().forall(p ->
p.metadataCache().getTopicPartitions(testTopicName).size() ==
alteredNumPartitions),
() -> "Timeout waiting for new assignment propagating to broker",
- org.apache.kafka.test.TestUtils.DEFAULT_MAX_WAIT_MS, 100L);
+ org.apache.kafka.test.TestUtils.DEFAULT_MAX_WAIT_MS, 500L);
Review Comment:
It turns out that the flakiness of the
`testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress` is not due
to the `DEFAULT_MAX_WAIT_MS`. So I've reverted this change. Thanks ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]