clolov commented on code in PR #15005:
URL: https://github.com/apache/kafka/pull/15005#discussion_r1427814012
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1073,13 +1088,29 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, ExecutionE
.iterator();
while (epochsToClean.hasNext()) {
int epoch = epochsToClean.next();
+ List<RemoteLogSegmentMetadata> listOfSegmentsToBeCleaned =
new ArrayList<>();
+ sizeOfDeletableSegmentsBytes = 0L;
Review Comment:
Yup, to paraphrase - we could have leftover undeleted segments and we need
to carry them forward in the calculations. I have amended this in subsequent
commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
