showuon commented on code in PR #15005:
URL: https://github.com/apache/kafka/pull/15005#discussion_r1426233918
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1041,10 +1060,20 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, ExecutionE
// and delete them accordingly.
// If the follower HAS NOT picked up the changes, and they become
the leader then they will go through this process
// again and delete them with the original deletion reason i.e.
size, time or log start offset breach.
+ BrokerTopicMetrics brokerTopicMetrics =
brokerTopicStats.topicStats(topicIdPartition.topic());
+ int partition = topicIdPartition.partition();
+ brokerTopicMetrics.recordRemoteDeleteBytesLag(partition,
sizeOfDeletableSegmentsBytes);
+ int segmentsLeftToDelete = segmentsToDelete.size();
+ brokerTopicMetrics.recordRemoteDeleteSegmentsLag(partition,
segmentsLeftToDelete);
Review Comment:
Should we also add the segments in L1095?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
