jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414519712
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##########
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: CompressionType,
time: Time
) extends PartitionWriter[T] {
+ private val threadLocalBufferSupplier = ThreadLocal.withInitial(
+ () => new BufferSupplier.GrowableBufferSupplier()
+ )
Review Comment:
Just for my understanding though -- in the past we relied on RequestLocal
for this sort of thing. Is the idea to move to ThreadLocal here so it is safer
and we don't run into things like
https://issues.apache.org/jira/browse/KAFKA-15653 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
