jolshan commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1414500105
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##########
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: CompressionType,
time: Time
) extends PartitionWriter[T] {
+ private val threadLocalBufferSupplier = ThreadLocal.withInitial(
+ () => new BufferSupplier.GrowableBufferSupplier()
+ )
Review Comment:
For more context on 4. There are assumptions in the code that a request is
handled on the same thread.
There was a bug in KIP-890 (see
[here](https://issues.apache.org/jira/browse/KAFKA-15653)) where we used the
wrong byte buffer and it caused NPEs and other exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
