philipnee commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1382109709
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java:
##########
@@ -24,21 +24,34 @@
public enum MemberState {
/**
- * Member has not joined a consumer group yet, or has been fenced and
needs to re-join.
+ * Member is not part of the group. This could be the case when it has
never joined (no call
+ * has been made to the subscribe API), or when the member intentionally
leaves the group
+ * after a call to the unsubscribe API.
*/
- UNJOINED,
+ NOT_IN_GROUP,
+
+ /**
+ * Member is attempting to join a consumer group. This could be the case
when joining for the
+ * first time, or when it has been fenced and tries to re-join.
+ */
+ JOINING,
/**
* Member has received a new target assignment (partitions could have been
assigned or
* revoked), and it is processing it. While in this state, the member will
* invoke the user callbacks for onPartitionsAssigned or
onPartitionsRevoked, and then make
* the new assignment effective.
*/
- // TODO: determine if separate state will be needed for assign/revoke (not
for now)
RECONCILING,
/**
- * Member is active in a group (heartbeating) and has processed all
assignments received.
+ * Member has completed reconciling an assignment received, and stays in
this state until the
+ * next heartbeat request is sent out to acknowledge the assignment to the
server.
+ */
+ SENDING_ACK_FOR_RECONCILED_ASSIGNMENT,
Review Comment:
`ACK_RECONCILATION_COMPLETE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
