lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1380694833
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##########
@@ -73,30 +84,55 @@ public interface MembershipManager {
/**
* @return Current assignment for the member.
*/
- ConsumerGroupHeartbeatResponseData.Assignment currentAssignment();
+ Set<TopicPartition> currentAssignment();
/**
- * Update the assignment for the member, indicating that the provided
assignment is the new
- * current assignment.
+ * @return Assignment that the member received from the server but hasn't
finished processing
+ * yet.
*/
- void
onTargetAssignmentProcessComplete(ConsumerGroupHeartbeatResponseData.Assignment
assignment);
+ Optional<ConsumerGroupHeartbeatResponseData.Assignment> targetAssignment();
Review Comment:
Totally, it seemed it was needed here at some point but not anymore.
Removing it & cleaning up, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
