aliehsaeedii commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1380262135
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##########
@@ -335,6 +342,42 @@ private static <R> QueryResult<R>
runWindowRangeQuery(final Query<R> query,
}
}
+ @SuppressWarnings("unchecked")
+ private static <R> QueryResult<R> runVersionedKeyQuery(final Query<R>
query,
+ final PositionBound
positionBound,
+ final QueryConfig
config,
+ final StateStore
store) {
+ if (store instanceof VersionedKeyValueStore) {
+ final VersionedKeyValueStore<Bytes, byte[]> versionedKeyValueStore
=
+ (VersionedKeyValueStore<Bytes, byte[]>) store;
+ if (query instanceof VersionedKeyQuery) {
Review Comment:
> Same as above -- I think we should remove this check, as the code
guarantees that it's true.
here I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
