aliehsaeedii commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1370015490
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##########
@@ -148,13 +205,38 @@ protected <R> QueryResult<R> runRangeQuery(final Query<R>
query,
throw new UnsupportedOperationException("Versioned stores do not
support RangeQuery queries at this time.");
}
+ @SuppressWarnings("unchecked")
@Override
protected <R> QueryResult<R> runKeyQuery(final Query<R> query,
Review Comment:
Should we reserve this for `KeyQuery`, and add a new `versionedKeyQuery`
method?
If you say so, I think we do not have simple key queries with versioned
state stores. Therefore, we can reuse the method name. But we can follow you
and change it to `versionedKeyQuery` or even have two separate methods for for
each of the versioned key query types. One for single ts and one for multi ts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
