divijvaidya commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1338463195
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+ private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+ val pw = new PrintWriter((remoteOffsetIndexFile(new
File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))
Review Comment:
You will notice that checkstyle is failing in the build (you can check the
CI by clicking the "details" button below) since we still didn't add space
after each comma.
```
* What went wrong:
Execution failed for task ':storage:checkstyleMain'.
> A failure occurred while executing
org.gradle.api.plugins.quality.internal.CheckstyleAction
> Checkstyle rule violations were found. See the report at:
file:///home/jenkins/workspace/Kafka_kafka-pr_PR-14459/storage/build/reports/checkstyle/main.html
Checkstyle files with violations: 1
Checkstyle violations by severity: [error:1]
```
I would suggest to run `./gradlew unitTest` locally to ensure that build is
successful before updating the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
