divijvaidya commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1338397666
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+ private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+ val pw = new PrintWriter((remoteOffsetIndexFile(new
File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))
Review Comment:
nit
spaces after `,` for each argument
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
timeIndex.flush()
}
}
+
+ private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+ val pw = new PrintWriter((remoteOffsetIndexFile(new
File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))
+ pw.write("Hello, world")
Review Comment:
please add a comment on why this is considered as "corrupted"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
