[GitHub] [kafka] mumrah commented on a diff in pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

[via GitHub]

mumrah commented on code in PR #13773:
URL: https://github.com/apache/kafka/pull/13773#discussion_r1231113907


##########
metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java:
##########
@@ -45,6 +46,7 @@ public Builder setMetadataVersion(MetadataVersion 
metadataVersion) {
             if 
(metadataVersion.isLessThan(MetadataVersion.MINIMUM_BOOTSTRAP_VERSION)) {
                 // When writing an image, all versions less than 3.3-IV0 are 
treated as 3.0-IV1.
                 // This is because those versions don't support 
FeatureLevelRecord.
+                setOrgMetadataVersion(metadataVersion);
                 setRawMetadataVersion(MetadataVersion.MINIMUM_KRAFT_VERSION);
             } else {
                 setRawMetadataVersion(metadataVersion);

Review Comment:
   Let's set both metadata versions here as well so we don't have to deal with 
a `null` later



##########
metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java:
##########
@@ -29,6 +29,7 @@
 public final class ImageWriterOptions {
     public static class Builder {
         private MetadataVersion metadataVersion;
+        private MetadataVersion orgMetadataVersion;

Review Comment:
   How about "requestedMetadataVersion" ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org