Owen-CH-Leung commented on code in PR #13773:
URL: https://github.com/apache/kafka/pull/13773#discussion_r1231250401
##########
metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java:
##########
@@ -45,6 +46,7 @@ public Builder setMetadataVersion(MetadataVersion
metadataVersion) {
if
(metadataVersion.isLessThan(MetadataVersion.MINIMUM_BOOTSTRAP_VERSION)) {
// When writing an image, all versions less than 3.3-IV0 are
treated as 3.0-IV1.
// This is because those versions don't support
FeatureLevelRecord.
+ setOrgMetadataVersion(metadataVersion);
setRawMetadataVersion(MetadataVersion.MINIMUM_KRAFT_VERSION);
} else {
setRawMetadataVersion(metadataVersion);
Review Comment:
Sure. I've set both fields in this function call. Note that I've also
modified the `ImageDowngradeTest` to use the `setMetadataVersion` instead of
`setRawMetadataVersion` (Maybe we should change `setRawMetadataVersion` to
private` also ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
