philipnee commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1163702789
##########
streams/src/main/java/org/apache/kafka/streams/errors/ProductionExceptionHandler.java:
##########
@@ -34,6 +35,18 @@ public interface ProductionExceptionHandler extends
Configurable {
ProductionExceptionHandlerResponse handle(final ProducerRecord<byte[],
byte[]> record,
final Exception exception);
+ /**
+ * Handles serialization exception and determine if the process should
continue. The default implementation is to
+ * fail the process.
+ *
+ * @param record the record that failed to serialize
+ * @param exception the exception that occurred during serialization
+ */
+ default ProductionExceptionHandlerResponse onSerializationException(final
ProducerRecord record,
Review Comment:
for the naming I'll change it back to the original kip's spec. The only
reason I would alter the kip is the exception type, it seems too loose as the
name suggests it only handles the serialization exception. But do you think it
is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
