philipnee commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1153927450
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -213,6 +212,31 @@ public <K, V> void send(final String topic,
keyClass,
valueClass),
exception);
+ } catch (final SerializationException exception) {
+ final ProducerRecord<K, V> record = new ProducerRecord<>(topic,
partition, timestamp, key, value, headers);
+ final
ProductionExceptionHandler.ProductionExceptionHandlerResponse response;
+ try {
+ response =
productionExceptionHandler.handleSerializationException(record, exception);
+ } catch (final Exception fatalUserException) {
+ log.error("Serialization error callback failed after
serialization error for record {}", record, fatalUserException);
+ final ProducerRecord<byte[], byte[]> rec = new
ProducerRecord<>(topic, partition, timestamp, keyBytes, valBytes, headers);
Review Comment:
valBytes is always null - maybe it is more straightforward to supply a null
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
