Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1129482786
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##########
@@ -167,8 +213,24 @@ public <P> Builder addPartitions(
}
public Builder merge(
- OffsetCommitResponseData newData
+ OffsetCommitResponseData newData,
+ Logger logger
) {
+ if (version >= 9) {
+ // This method is called after the group coordinator committed
the offsets. The group coordinator
+ // provides the OffsetCommitResponseData it built in the
process. As of now, this data does
+ // not contain topic ids, so we resolve them here.
+ newData.topics().forEach(topic -> {
+ Uuid topicId =
topicResolver.getTopicId(topic.name()).orElse(Uuid.ZERO_UUID);
+ if (Uuid.ZERO_UUID.equals(topicId)) {
Review Comment:
Modified the PR so that the server now sends an `UNKNOWN_SERVER_ERROR` when
this happens, in the code moved to the future handler in `KafkaApis`. Would
this behaviour be acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
