Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1129267206
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1352,8 +1370,22 @@ public void handle(OffsetCommitResponse commitResponse,
RequestFuture<Void> futu
Set<String> unauthorizedTopics = new HashSet<>();
for (OffsetCommitResponseData.OffsetCommitResponseTopic topic :
commitResponse.data().topics()) {
+ String topicName = topic.name();
+
+ if (commitResponse.version() >= 9) {
+ topicName =
topicResolver.getTopicName(topic.topicId()).orElse(null);
+
+ if (topicName == null) {
+ // OffsetCommit responses version 9 must use topic
IDs. The topic's ID must have been
+ // known by the client which sent the
OffsetCommitRequest but was removed from the metadata
+ // before the response was received.
Review Comment:
Yes, that is right. Apologies, this is a fundamental
misunderstanding/overlook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
