C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1122150546
########## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.config.provider; + +import org.apache.kafka.common.config.ConfigData; +import org.apache.kafka.common.config.ConfigException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +public class EnvVarConfigProvider implements ConfigProvider { + private final Map<String, String> envVarMap; + + public EnvVarConfigProvider() { + envVarMap = getEnvVars(); + } + + public EnvVarConfigProvider(Map<String, String> envVarsAsArgument) { + envVarMap = envVarsAsArgument; + } + + private static final Logger log = LoggerFactory.getLogger(EnvVarConfigProvider.class); + + @Override + public void configure(Map<String, ?> configs) { + } Review Comment: > This isn't stopped by a protected REST API. I don't really agree with this assessment, since a protected REST API does prevent untrusted users from submitting connector configurations. Generally speaking we've only tried to take unfettered access to Connect clusters into account for features that are enabled by default. Given that this feature is disabled by default, it's not necessary to take steps to guard it against malicious connector configurations. It's also worth noting that, if you're running a Connect cluster where non-trusted users are able to submit connector configurations, a REST extension or a fork of this config provider are both reasonable alternatives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
