hachikuji commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1098020205
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3509,6 +3510,13 @@ class KafkaApis(val requestChannel: RequestChannel,
)
}
+ def handleConsumerGroupHeartbeat(request: RequestChannel.Request):
CompletableFuture[Unit] = {
+ val consumerGroupHeartbeatRequest =
request.body[ConsumerGroupHeartbeatRequest]
+ // KIP-848 is not implemented yet so return UNSUPPORTED_VERSION.
+ requestHelper.sendMaybeThrottle(request,
consumerGroupHeartbeatRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
Review Comment:
Would it be overkill to have a unit test for this in `KafkaApisTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
