yufeiyan1220 commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397837046
> Thanks for the PR and the issue @yufeiyan1220 - I wonder if the clean up is necessary, as the metrics will be closed upon the client closing. Willing to hear what others say. I found that problem when I tried to create and close consumer frequently. Just like the test case I have made in `KafkaConsumerTest.java`, these consumer coordinator metrics are still present if I does not close these metrics explicitly. I think most of users might not try to create and close consumer frequently, but there is a potential for memory leak actually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org