[GitHub] [kafka] philipnee commented on a diff in pull request #13138: MINOR: Small cleanups in refactored consumer implementation

[via GitHub]

philipnee commented on code in PR #13138:
URL: https://github.com/apache/kafka/pull/13138#discussion_r1082970121


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -97,8 +97,8 @@ private void trySend(final long currentTimeMs) {
             unsent.timer.update(currentTimeMs);
             if (unsent.timer.isExpired()) {
                 iterator.remove();
-                unsent.callback.ifPresent(c -> c.onFailure(new 
TimeoutException(
-                        "Failed to send request after " + 
unsent.timer.timeoutMs() + " " + "ms.")));
+                unsent.callback.onFailure(new TimeoutException(
+                    "Failed to send request after " + unsent.timer.timeoutMs() 
+ " " + "ms."));

Review Comment:
   maybe 
   ` "Failed to send request after " + unsent.timer.timeoutMs() + " ms."`
   
   I'm not sure why I added an extra  `+ " "`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org