hachikuji opened a new pull request, #13138: URL: https://github.com/apache/kafka/pull/13138
This patch contains a few cleanups in the new refactored consumer logic: - Use `CompletableFuture` instead of `RequestFuture` in `NetworkClientDelegate`. This is a much more extensible API and it avoids tying the new implementation to `ConsumerNetworkClient`. - Fix call to `isReady` in `NetworkClientDelegate`. We need the call to `ready` to initiate the connection. - Ensure backoff is enforced even after successful `FindCoordinator` request. This avoids a tight loop while metadata is converging after a coordinator change. - `RequestState` was incorrectly use the reconnect backoff as the retry backoff. In fact, we don't currently have a retry backoff max, so the use of `ExponentialBackoff` is unnecessary, but I've left it since we may add this in https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients. - Minor cleanups in test cases to avoid unused classes/fields. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
