satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1070596038
########## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ########## @@ -72,7 +71,7 @@ public CheckpointFile(File file, tempPath = Paths.get(absolutePath.toString() + ".tmp"); } - public void write(Collection<T> entries) throws IOException { + public void write(List<T> entries) throws IOException { Review Comment: This is done to make write and read API consistent like below. ``` public void write(List<T> entries) throws IOException public List<T> read() throws IOException ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org