[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

[GitBox]

kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1057895052


##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -346,8 +346,16 @@ private void cancelInFlightRequests(String nodeId, long 
now, Collection<ClientRe
             }
 
             if (!request.isInternalRequest) {
-                if (responses != null)
-                    responses.add(request.disconnected(now, null));
+                if (responses != null) {
+                    ClientResponse disconnected;

Review Comment:
   This code has been refactored and there's no longer a new local variable set.



##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -346,8 +346,16 @@ private void cancelInFlightRequests(String nodeId, long 
now, Collection<ClientRe
             }
 
             if (!request.isInternalRequest) {
-                if (responses != null)
-                    responses.add(request.disconnected(now, null));
+                if (responses != null) {
+                    ClientResponse disconnected;
+
+                    if (request.timeElapsedSinceSendMs(now) > 
request.requestTimeoutMs)

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org