[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

[via GitHub]

kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1082998126


##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2519,7 +2519,7 @@ public void testInflightBatchesExpireOnDeliveryTimeout() 
throws InterruptedExcep
 
         Map<TopicPartition, ProduceResponse.PartitionResponse> responseMap = 
new HashMap<>();
         responseMap.put(tp0, new 
ProduceResponse.PartitionResponse(Errors.NONE, 0L, 0L, 0L));
-        client.respond(new ProduceResponse(responseMap));
+        client.respond(new ProduceResponse(responseMap), true, true);

Review Comment:
   Ah! I reverted that change and added a dedicated 
`testMetadataRefreshOnRequestTimeout` test method to `SenderTest`. Let me know 
if that new test is sufficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org