cmccabe commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1043911867
##########
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##########
@@ -51,7 +51,7 @@
},
{ "name": "Rack", "type": "string", "versions": "0+", "nullableVersions":
"0+",
"about": "The rack which this broker is in." },
- { "name": "IsMigratingZkBroker", "type": "int8", "versions": "0+",
"taggedVersions": "0+", "tag": 0, "ignorable": true,
+ { "name": "IsMigratingZkBroker", "type": "bool", "versions": "0+",
"taggedVersions": "0+", "tag": 0, "ignorable": true,
Review Comment:
see my comment in the main PR conversation thread: this should not be tagged
and we need a new version of the rpc ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
