cmccabe commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1043908893
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -2230,8 +2230,15 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
validateAdvertisedListenersNonEmptyForBroker()
} else {
// ZK-based
- // controller listener names must be empty when not in KRaft mode
- require(controllerListenerNames.isEmpty,
s"${KafkaConfig.ControllerListenerNamesProp} must be empty when not running in
KRaft mode: ${controllerListenerNames.asJava}")
+ if (migrationEnabled) {
+ validateNonEmptyQuorumVotersForKRaft()
+ require(controllerListenerNames.nonEmpty,
Review Comment:
this seems like a bug. in migration mode you want it to be non-empty, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
