hachikuji commented on code in PR #12915:
URL: https://github.com/apache/kafka/pull/12915#discussion_r1036571472
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -1678,6 +1678,39 @@ public void testMultipleAddPartitionsPerForOneProduce()
throws InterruptedExcept
assertTrue(secondResponseFuture.isDone());
}
+ @Test
+ public void testRetriableErrors() {
Review Comment:
Is it possible to parameterize this test case so that we can verify
retriable errors other than REQUEST_TIMED_OUT (e.g. CONCURRENT_TRANSACTIONS).
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -1678,6 +1678,39 @@ public void testMultipleAddPartitionsPerForOneProduce()
throws InterruptedExcept
assertTrue(secondResponseFuture.isDone());
}
+ @Test
+ public void testRetriableErrors() {
Review Comment:
Is it possible to parameterize this test case so that we can verify
retriable errors other than REQUEST_TIMED_OUT (e.g. CONCURRENT_TRANSACTIONS)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
