jolshan commented on code in PR #12915:
URL: https://github.com/apache/kafka/pull/12915#discussion_r1036369902
##########
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##########
@@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int,
if (nextProducerId > currentProducerIdBlock.lastProducerId) {
val block = nextProducerIdBlock.poll(maxWaitMs, TimeUnit.MILLISECONDS)
if (block == null) {
- throw Errors.REQUEST_TIMED_OUT.exception("Timed out waiting for next
producer ID block")
+ throw Errors.CONCURRENT_TRANSACTIONS.exception("Timed out waiting
for next producer ID block")
Review Comment:
Hmm -- I may have misunderstood some of our offline discussions. I believe a
KIP is needed to bump the request version but since concurent transactions is
already handled by the client for this request, my understanding is that it is
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
