dajac commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1024047722
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##########
@@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set<String>
allTopics,
return isAllSubscriptionsEqual;
}
+ // visible for testing
+ MemberData memberDataFromSubscription(Subscription subscription) {
+ if (!subscription.ownedPartitions().isEmpty() &&
subscription.generationId().isPresent()) {
Review Comment:
I wonder if this is 100% correct. Could we have a case where subscription v3
is used but no owned partitions are reported by the member? For instance, this
could happen if the group has more members than partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
