cmccabe commented on code in PR #12715:
URL: https://github.com/apache/kafka/pull/12715#discussion_r991501077
##########
metadata/src/main/java/org/apache/kafka/image/MetadataImage.java:
##########
@@ -120,17 +116,17 @@ public AclsImage acls() {
return acls;
}
- public void write(Consumer<List<ApiMessageAndVersion>> out) {
- MetadataVersion metadataVersion = features.metadataVersion();
+ public void write(ImageWriter writer, ImageWriterOptions options) {
// Features should be written out first so we can include the
metadata.version at the beginning of the
// snapshot
- features.write(out);
- cluster.write(out, metadataVersion);
- topics.write(out);
- configs.write(out);
- clientQuotas.write(out);
- producerIds.write(out);
- acls.write(out);
+ features.write(writer, options);
+ cluster.write(writer, options);
+ topics.write(writer, options);
+ configs.write(writer, options);
+ clientQuotas.write(writer, options);
+ producerIds.write(writer, options);
+ acls.write(writer, options);
+ writer.freeze();
Review Comment:
I have revised this code so that there is just a close function which takes
a boolean. We call it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
