cmccabe commented on code in PR #12715:
URL: https://github.com/apache/kafka/pull/12715#discussion_r991443425
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -390,15 +389,18 @@ class BrokerMetadataListener(
}
class GetImageRecordsEvent(future:
CompletableFuture[util.List[ApiMessageAndVersion]])
- extends EventQueue.FailureLoggingEvent(log) with
Consumer[util.List[ApiMessageAndVersion]] {
- val records = new util.ArrayList[ApiMessageAndVersion]()
- override def accept(batch: util.List[ApiMessageAndVersion]): Unit = {
- records.addAll(batch)
- }
-
+ extends EventQueue.FailureLoggingEvent(log) {
override def run(): Unit = {
- _image.write(this)
- future.complete(records)
+ val writer = new InMemoryImageWriter()
+ val options = new ImageWriterOptions.Builder().
+ setMetadataVersion(_image.features().metadataVersion()).
+ build()
+ try {
+ _image.write(writer, options)
+ } finally {
+ writer.close()
+ }
Review Comment:
try-with-resource does not exist in Scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
