mdedetrich commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r936511846
########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.8 +runner.dialect = scala213 Review Comment: The Scala 2.13 dialect is backwards compatible with 2.12. I have applied the dialect when updating from scalafmt 2 to scalafmt 3 with various popular OSS Scala projects and there isn't any issues (in any case the Scala code that is used im Kafka is quite conservative) > I have verified that the style guide we follow for this project is not prescriptive about formatting of the docs. Hence, your change should be ok. Do you think it makes sense to format the docs or should I leave the PR as is? > Note that build is failing related to changes in this PR. We would probably need to fix the error but I think I might have already fixed it in MINOR: Catch InvocationTargetException explicitly and propagate underlying cause #12230 If that lands, then the check should pass here. In that case it's sensible to wait for your PR to land and then I can rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
