divijvaidya commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r936426643
########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.8 +runner.dialect = scala213 Review Comment: We still support scala 2.12 in this project. By specifying the dialect as 2.13, would we fail where syntax for 2.12 is used? If yes, are there any such cases in the project? (The build should tell us that after the existing spotless check passes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
