vvcephei commented on code in PR #12458:
URL: https://github.com/apache/kafka/pull/12458#discussion_r933727376
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -205,11 +211,17 @@ def collect_results(self, sleep_time_secs):
return data
@cluster(num_nodes=7)
+ @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
+ broker_type=["leader"],
+ num_threads=[1, 3],
+ sleep_time_secs=[120],
+ metadata_quorum=[quorum.remote_kraft])
@matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
broker_type=["leader", "controller"],
num_threads=[1, 3],
sleep_time_secs=[120])
Review Comment:
Thanks, @AlanConfluent . I was actually making a slightly different
suggestion, namely to explicitly include `metadata_quorum=[quorum.zk]` in this
second matrix config, and to remove the default parameter value
`metadata_quorum=quorum.zk` from the method signature.
Github charmingly won't let me do a suggestion to make this clearer because
the diff includes a deleted line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
