vvcephei commented on code in PR #12458:
URL: https://github.com/apache/kafka/pull/12458#discussion_r933394405
##########
tests/kafkatest/tests/streams/streams_standby_replica_test.py:
##########
@@ -73,9 +77,9 @@ def test_standby_tasks_rebalance(self):
processor_3.start()
- self.wait_for_verification(processor_1, "ACTIVE_TASKS:2
STANDBY_TASKS:[1-3]", processor_1.STDOUT_FILE)
- self.wait_for_verification(processor_2, "ACTIVE_TASKS:2
STANDBY_TASKS:[1-3]", processor_2.STDOUT_FILE)
- self.wait_for_verification(processor_3, "ACTIVE_TASKS:2
STANDBY_TASKS:[1-3]", processor_3.STDOUT_FILE)
+ self.wait_for_verification(processor_1, "ACTIVE_TASKS:2
STANDBY_TASKS:2", processor_1.STDOUT_FILE)
+ self.wait_for_verification(processor_2, "ACTIVE_TASKS:2
STANDBY_TASKS:2", processor_2.STDOUT_FILE)
+ self.wait_for_verification(processor_3, "ACTIVE_TASKS:2
STANDBY_TASKS:2", processor_3.STDOUT_FILE)
Review Comment:
What's up with this verification change? It looks like you're increasing the
specificity of the verification here, which is good. I'm wondering if it has
some relationship to the quorum change, of if it's just on the side.
##########
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##########
@@ -205,11 +211,17 @@ def collect_results(self, sleep_time_secs):
return data
@cluster(num_nodes=7)
+ @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
+ broker_type=["leader"],
+ num_threads=[1, 3],
+ sleep_time_secs=[120],
+ metadata_quorum=[quorum.remote_kraft])
@matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
broker_type=["leader", "controller"],
num_threads=[1, 3],
sleep_time_secs=[120])
Review Comment:
What do you think about explicitly specifying `quorum.zk` instead of relying
on the default? It's maybe mildly more verbose, but it avoids having to think
through overrides when you're debugging a test failure out of the blue.
If you're in favor, I'd suggest just removing all the default parameter
values that got added here to be sure everything is explicitly configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
