lihaosky commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r916381888
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##########
@@ -55,6 +55,10 @@ <K, V> SessionStore<K, V> buildSessionStore(final long
retentionPeriod,
valueSerde).build();
}
+ StoreType getStoreType() {
Review Comment:
For `shouldRemoveExpired`, the RocksDB version has different params for
session window.
For `shouldNotExpireFromOpenIterator`, it's not supported in
RocksDBSessionStore
For `shouldMatchPositionAfterPut`, the RocksDB version has different cast
than `InMemorySessionStore`.
So we could put `shouldRemoveExpired` and `shouldMatchPositionAfterPut` in
parent class and add different logic depending on store type. We can also leave
it here. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
