mjsax commented on code in PR #12370:
URL: https://github.com/apache/kafka/pull/12370#discussion_r915364409
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImpl.java:
##########
@@ -289,7 +289,10 @@ private <VR> StoreBuilder<SessionStore<K, VR>>
materialize(final MaterializedInt
// do not enable cache if the emit final strategy is used
if (materialized.cachingEnabled() && emitStrategy.type() !=
EmitStrategy.StrategyType.ON_WINDOW_CLOSE) {
builder.withCachingEnabled();
+ } else {
+ builder.withCachingDisabled();
Review Comment:
Why do we need this call? I thought we only add tests in this PR? Is the
feature not completed yet and we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
