[GitHub] [kafka] tombentley commented on a diff in pull request #12296: KAFKA-13996: log.cleaner.io.max.bytes.per.second can be changed dynamically

[GitBox]

tombentley commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r916026938


##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -186,11 +186,18 @@ class LogCleaner(initialConfig: CleanerConfig,
   }
 
   /**
-    * Reconfigure log clean config. This simply stops current log cleaners and 
creates new ones.
+    * Reconfigure log clean config. It will (1) update desiredRatePerSec in 
Throttler with logCleanerIoMaxBytesPerSecond if necessary (2) stop current log 
cleaners and create new ones.

Review Comment:
   ```suggestion
       * Reconfigure log clean config. The will:
       * 1. update desiredRatePerSec in Throttler with 
logCleanerIoMaxBytesPerSecond, if necessary 
       * 2. stop current log cleaners and create new ones.
   ```



##########
core/src/main/scala/kafka/utils/Throttler.scala:
##########
@@ -36,7 +36,7 @@ import scala.math._
  * @param time: The time implementation to use
  */
 @threadsafe
-class Throttler(desiredRatePerSec: Double,
+class Throttler(var desiredRatePerSec: Double,

Review Comment:
   That seems reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org