tyamashi-oss commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r913695502
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -191,6 +191,13 @@ class LogCleaner(initialConfig: CleanerConfig,
*/
override def reconfigure(oldConfig: KafkaConfig, newConfig: KafkaConfig):
Unit = {
Review Comment:
Thank you. Java doc have been updated about updating the
throttler.desiredRatePerSec.
https://github.com/apache/kafka/pull/12296/commits/04264960fe7300e02dd48d9f7aee66390754a417
##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -191,6 +191,13 @@ class LogCleaner(initialConfig: CleanerConfig,
*/
override def reconfigure(oldConfig: KafkaConfig, newConfig: KafkaConfig):
Unit = {
config = LogCleaner.cleanerConfig(newConfig)
+
+ val maxIoBytesPerSecond = config.maxIoBytesPerSecond;
+ if (maxIoBytesPerSecond != oldConfig.logCleanerIoMaxBytesPerSecond) {
+ info(s"Updating logCleanerIoMaxBytesPerSecond: $maxIoBytesPerSecond")
+ throttler.updateDesiredRatePerSec(maxIoBytesPerSecond)
+ }
Review Comment:
I’ve added a test for that. I could not find reconfigure test that would be
a good reference that I could imitate, so this is a test in my own way.
https://github.com/apache/kafka/pull/12296/commits/1a574d67ad1685ce776bb45896fe6dd72992dbef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
