cadonna commented on code in PR #12289:
URL: https://github.com/apache/kafka/pull/12289#discussion_r912802169
##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -221,24 +224,24 @@ public void shouldQuerySpecificActivePartitionStores()
throws Exception {
assertThat(store1.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams2,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams1, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams1, storeQueryParam2).get(key));
assertThat(
- exception.getMessage(),
- containsString("The specified partition 1 for store
source-table does not exist.")
+ exception.getMessage(),
+ containsString("The specified partition 1 for
store source-table does not exist.")
Review Comment:
nit:
```suggestion
exception.getMessage(),
containsString("The specified partition 1 for store
source-table does not exist.")
```
##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -210,8 +213,8 @@ public void shouldQuerySpecificActivePartitionStores()
throws Exception {
}
final StoreQueryParameters<ReadOnlyKeyValueStore<Integer,
Integer>> storeQueryParam2 =
- StoreQueryParameters.<ReadOnlyKeyValueStore<Integer,
Integer>>fromNameAndType(TABLE_NAME, keyValueStore())
- .withPartition(keyDontBelongPartition);
+ StoreQueryParameters.<ReadOnlyKeyValueStore<Integer,
Integer>>fromNameAndType(TABLE_NAME, keyValueStore())
+ .withPartition(keyDontBelongPartition);
Review Comment:
nit: we usually indent 4 spaces.
```suggestion
StoreQueryParameters.<ReadOnlyKeyValueStore<Integer,
Integer>>fromNameAndType(TABLE_NAME, keyValueStore())
.withPartition(keyDontBelongPartition);
```
##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -221,24 +224,24 @@ public void shouldQuerySpecificActivePartitionStores()
throws Exception {
assertThat(store1.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams2,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams1, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams1, storeQueryParam2).get(key));
assertThat(
- exception.getMessage(),
- containsString("The specified partition 1 for store
source-table does not exist.")
+ exception.getMessage(),
+ containsString("The specified partition 1 for
store source-table does not exist.")
);
} else {
assertThat(store2.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams1,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams2, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams2, storeQueryParam2).get(key));
assertThat(
- exception.getMessage(),
- containsString("The specified partition 1 for store
source-table does not exist.")
+ exception.getMessage(),
+ containsString("The specified partition 1 for
store source-table does not exist.")
Review Comment:
nit:
```suggestion
exception.getMessage(),
containsString("The specified partition 1 for store
source-table does not exist.")
```
##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -221,24 +224,24 @@ public void shouldQuerySpecificActivePartitionStores()
throws Exception {
assertThat(store1.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams2,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams1, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams1, storeQueryParam2).get(key));
Review Comment:
nit
```suggestion
assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams1, storeQueryParam2).get(key));
```
##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -221,24 +224,24 @@ public void shouldQuerySpecificActivePartitionStores()
throws Exception {
assertThat(store1.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams2,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams1, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams1, storeQueryParam2).get(key));
assertThat(
- exception.getMessage(),
- containsString("The specified partition 1 for store
source-table does not exist.")
+ exception.getMessage(),
+ containsString("The specified partition 1 for
store source-table does not exist.")
);
} else {
assertThat(store2.get(key), is(notNullValue()));
assertThat(getStore(kafkaStreams1,
storeQueryParam2).get(key), is(nullValue()));
final InvalidStateStoreException exception =
- assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams2, storeQueryParam2).get(key));
+ assertThrows(InvalidStateStoreException.class, ()
-> getStore(kafkaStreams2, storeQueryParam2).get(key));
Review Comment:
nit:
```suggestion
assertThrows(InvalidStateStoreException.class, () ->
getStore(kafkaStreams2, storeQueryParam2).get(key));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
