mdedetrich commented on code in PR #12289:
URL: https://github.com/apache/kafka/pull/12289#discussion_r906835016


##########
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##########
@@ -535,17 +532,26 @@ public void 
shouldQueryStoresAfterAddingAndRemovingStreamThread() throws Excepti
         });
     }
 
+    private Matcher<String> retrievableException() {
+        return is(
+                anyOf(
+                        containsString("Cannot get state store source-table 
because the stream thread is PARTITIONS_ASSIGNED, not RUNNING"),
+                        containsString("The state store, source-table, may 
have migrated to another instance"),
+                        containsString("Cannot get state store source-table 
because the stream thread is STARTING, not RUNNING"),
+                        containsString("The specified partition 1 for store 
source-table does not exist.")

Review Comment:
   > The reason is that a bug could also throw that exception and we would just 
retry. 
   
   Agreed but if this is the case (and its a consistent bug) it would hit the 
timeout. Tbh investigating this was a bit out of my depth, maybe its wise to do 
a separate PR if we can find a better solution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to