mjsax commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r909109939
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##########
@@ -191,7 +204,14 @@ public void put(final Bytes rawBaseKey,
@Override
public byte[] get(final Bytes rawKey) {
- final S segment =
segments.getSegmentForTimestamp(baseKeySchema.segmentTimestamp(rawKey));
+ final long timestampFromRawKey =
baseKeySchema.segmentTimestamp(rawKey);
+ // check if timestamp is expired
+ if (timestampFromRawKey < observedStreamTime - retentionPeriod + 1) {
Review Comment:
Similar to above: is `+1` correct here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
