mjsax commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r909109804
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##########
@@ -119,6 +128,10 @@ public void remove(final Bytes rawBaseKey) {
abstract protected KeyValue<Bytes, byte[]> getIndexKeyValue(final Bytes
baseKey, final byte[] baseValue);
+ protected long getActualFrom(final long from) {
+ return Math.max(from, observedStreamTime - retentionPeriod + 1);
Review Comment:
I think we allow `retentionPeriod == 0` and thus, I am wondering if `+ 1` is
correct here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
