[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

[GitBox]

mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r907879361


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedSessionKeySchemas.java:
##########
@@ -204,7 +203,8 @@ public static void writeBinary(final ByteBuffer buf,
                                        final long endTime) {
             buf.putLong(endTime);
             buf.putLong(startTime);
-            buf.put(key.get());
+            if (key != null)

Review Comment:
   Can `key` ever be `null` here? (nit: add `{}` to block)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org