[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N][Emit final] Emit final for session window aggregations

[GitBox]

mjsax commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r907876784


##########
streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java:
##########
@@ -39,6 +39,13 @@
  */
 public interface SessionStore<K, AGG> extends StateStore, 
ReadOnlySessionStore<K, AGG> {
 
+    // TODO: javadoc; both ends are inclusive
+    default KeyValueIterator<Windowed<K>, AGG> findSessions(final Instant 
earliestSessionEndTime,

Review Comment:
   Why did you pick `Instant` over `long` (wondering if `long` might be better 
as it's more an internal API)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org