On Sunday, February 19, 2023 at 2:50:44 PM UTC-7 Olivier Lamy wrote: On Mon, 20 Feb 2023 at 00:54, Mark Waite wrote: > > I like the idea. Would that have detected the specific problem that prompted the idea? Are there tests in plugins that depend on the API plugin that would have detected the issue?
tbh not sure we will detect all possible issues :) but at least we could prevent some. > > If there aren't tests that would have detected the issue, wouldn't it be better to add tests to the API plugin to prevent that problem in the future? why not but I'm not sure how we can collect all usage in downstream plugins. I'm not quite sure how to implement this technically because downstream plugins may use the api-plugin as direct dependency with version or using the bom so this means we would have to inject an incremental bom or change version. how to detect all downstream plugins? manual actions in the plugin-api by adding manually in Jenkinsfile the downstream plugins? having some scanning on artifactory to detect links? (maybe something already exists in Artifactory via some provided API). I think that the necessary information may already be available from the update center, since it is visible on the dependencies page of the plugins site. Though, possibly I'm not understanding the issue you're raising... https://plugins.jenkins.io/kubernetes-client-api/#dependencies shows that there are four plugins that depend on the Kubernetes client API plugin: Kubernetes Kubernetes Credentials Kubernetes Credentials Provider OpenShift Sync https://plugins.jenkins.io/okhttp-api/#dependencies shows the plugins that depend on the okhttp API plugin: Azure AD CloudBees Docker Hub/Registry Notification CloudBees Feature Management CodeThreat GitHub GitHub API GitHub Branch Source Helix ALM Test Management LoadRunner Cloud OpenTelemetry Performance Signature: Dynatrace Performance Signature: Dynatrace AppMon Pipeline Input Step Notification REST List Parameter -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/39c97990-afb7-4add-8aba-779ac9b98af8n%40googlegroups.com.
