On Mon, 20 Feb 2023 at 00:54, Mark Waite <mark.earl.wa...@gmail.com> wrote: > > I like the idea. Would that have detected the specific problem that prompted > the idea? Are there tests in plugins that depend on the API plugin that > would have detected the issue?
tbh not sure we will detect all possible issues :) but at least we could prevent some. > > If there aren't tests that would have detected the issue, wouldn't it be > better to add tests to the API plugin to prevent that problem in the future? why not but I'm not sure how we can collect all usage in downstream plugins. I'm not quite sure how to implement this technically because downstream plugins may use the api-plugin as direct dependency with version or using the bom so this means we would have to inject an incremental bom or change version. how to detect all downstream plugins? manual actions in the plugin-api by adding manually in Jenkinsfile the downstream plugins? having some scanning on artifactory to detect links? (maybe something already exists in Artifactory via some provided API). > > On Friday, February 17, 2023 at 9:03:44 PM UTC-7 olive...@gmail.com wrote: >> >> Hi >> As we use more and more *-api-plugin dependencies, breaking release of >> one of those might break a few downstream dependent plugins.. >> Such this issue https://issues.jenkins.io/browse/JENKINS-70637 which >> has broken a few users including myself (that's probably why I'm >> writing this email 🤣) >> As the *-api-plugin doesn't have any tests there is no way to figure >> out potential issues :( >> I wonder how we could improve to have some tests with downstream plugins? >> maybe some solution "a la" PCT with injecting the upgrade version to >> downstream plugins and run the tests? >> >> Thoughts? >> >> cheers >> -- >> Olivier > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/b9f57672-7cae-4c4d-8486-2f4828aa8d2an%40googlegroups.com. -- Olivier Lamy http://linkedin.com/in/olamy -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPoyBqQURRQP4-CFHLBiov5Q6zvpVMBipGSwFtfuks6L1BUtyw%40mail.gmail.com.
