[
https://issues.apache.org/jira/browse/YUNIKORN-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816558#comment-17816558
]
Chia-Ping Tsai commented on YUNIKORN-2405:
------------------------------------------
[~wilfreds] My purpose was to unify the word in the "logging" files. Hence, I
prepared to make minimal changes in this jira.
{code:java}
Since all our code also uses <kind>ID for the variables having the mixed case
<kind>Id in messages looks incorrect. We should move to fully upper cased
version of ID. For the simple variable not per <kind> it would be ID (exported)
or id (not exported)/ {code}
+1
{code:java}
We have around 100 places with mixed case use that should be fully upper case
uses. Not sure if we want to tackle this for 1.5 or if we should do this for
1.6 {code}
It seems to me the 1.6 is good choice. There is no patch version so we don't
need to worry the diff of code base between 1.5 and 1.6. In other words, we
don't cherry-pick any patch to release 1.5.1, and so the code diff won't kill
us :)
> Unify the word "allocationId"
> -----------------------------
>
> Key: YUNIKORN-2405
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2405
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Ryan Lo
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Our logging has following "allocationUid", "allocationid", and "allocationId"
> spellings of words. We should unify the spelling to "allocationId".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
