[
https://issues.apache.org/jira/browse/YUNIKORN-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816468#comment-17816468
]
Wilfred Spiegelenburg commented on YUNIKORN-2405:
-------------------------------------------------
Our use case throughout should have been to name variable as {{allocationID}}
both I and D upper cased. We follow the
[https://go.dev/wiki/CodeReviewComments#initialisms] for our code. I would have
expected the linter to comment on this, sadly it did not.
Since all our code also uses {{<kind>ID}} for the variables having the mixed
case {{<kind>Id}} in messages looks incorrect. We should move to fully upper
cased version of ID. For the simple variable not per {{<kind>}} it would be ID
(exported) or id (not exported)/
In some spots we have no choice, {{osUser.GroupIds()}}, as it is not defined by
us. We do need to move away from the mixed case setup. and if ID is used behind
a type etc we should only use the full upper case version.
We have around 100 places with mixed case use that should be fully upper case
uses. Not sure if we want to tackle this for 1.5 or if we should do this for 1.6
> Unify the word "allocationId"
> -----------------------------
>
> Key: YUNIKORN-2405
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2405
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Ryan Lo
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> Our logging has following "allocationUid", "allocationid", and "allocationId"
> spellings of words. We should unify the spelling to "allocationId".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
